Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project machine-reservations command. #318

Merged
merged 21 commits into from
Oct 7, 2024
Merged

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Sep 17, 2024

Includes first tests within this project! 🎉

@Gerrit91 Gerrit91 mentioned this pull request Sep 19, 2024
8 tasks
@@ -36,6 +36,26 @@ type config struct {
listPrinter printers.Printer
}

// Execute is the entrypoint of the cloudctl application
func Execute() {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only moved to the top, did not change anything here

@Gerrit91 Gerrit91 marked this pull request as ready for review October 2, 2024 12:23
@Gerrit91 Gerrit91 requested review from mwennrich and vknabel October 2, 2024 12:24
Copy link
Collaborator

@vknabel vknabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine from my pov!

@Gerrit91 Gerrit91 merged commit 8dc2221 into master Oct 7, 2024
5 checks passed
@Gerrit91 Gerrit91 deleted the size-reservations branch October 7, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants